feat: release_project_sync script for review sync #6250
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
✅ All translation files are valid. This comment has been posted by the |
There was a problem hiding this comment.
Overall this looks great! Only comment I have is that some of the code is quite similar to code in https://github.com/openedx/openedx-translations/blob/main/scripts/fix_transifex_resource_names.py, so it might be nice to pull some of that out into a shared file at some point, but that absolutely should not block merging/running this!
| TRANSIFEX_API_TOKEN: ${{ secrets.TRANSIFEX_API_TOKEN }} | ||
| run: | | ||
| make translations_scripts_requirements | ||
| python ./scripts/release_project_sync.py redwood |
There was a problem hiding this comment.
another non-blocking comment - we'll likely want to update this to not be hardcoded and instead be an option like we have in https://github.com/openedx/openedx-translations/blob/main/.github/workflows/extract-translation-source-files.yml
There was a problem hiding this comment.
done.
Only comment I have is that some of the code is quite similar to code in https://github.com/openedx/openedx-translations/blob/main/scripts/fix_transifex_resource_names.py, so it might be nice to pull some of that out into a shared file at some point, but that absolutely should not block merging/running this!
I think the reuse might be overrated here since it's mostly a single method for getting the project. But a noteworthy point for sure.
OmarIthawi
force-pushed
the
release_cut
branch
2 times, most recently
from
2d4dd23 to
c541bee
Compare
|
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sync reviews and tags from the
openedx-translationsproject intoopenedx-translations-<release-name>projects.