-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"A non-exhaustive list of valid values defined by this specification are" is weird language #138
Comments
in the first example, in the second case, parameters that follow (mandatory, value_type, display) is the non-exhaustive list. |
Isn't that "an exhaustive list of the values defined by this specification"? Or are there more values defined elsewhere in VCI? i.e. I read "A non-exhaustive list of valid values defined by this specification are" as "this is some of the values defined by this specification, there are also other values defined in other sections of this specification". So if we look at:
I guess the intention is something like:
? |
I would drop the word "valid" from the phrases "valid values" and "valid parameters" since it doesn't add anything to the meaning. I can add this change to PR #191 if people agree. |
I think so. I think I also do think |
…ion' (#238) editorial. 2 approvals. * Clarify 'non-exhaustive list of the values defined by this specification' closes #138 * Apply suggestions from code review Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com> * Fix other places I'd removed 'defined by this specification' --------- Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
The current draft contains phrases about "non-exhaustive list of valid values defined by this specification" in a few places:
(e.g. https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#appendix-E.2.2 )
(e.g. https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#appendix-E.1.1.2 )
In both cases I've not been able to find an exhaustive list of the values that the specification does actually define. I'm not sure exactly what is meant, in other parts of the specification language like "Below is a non-exhaustive list of valid parameters that MAY be included" is used which may be the intention, or perhaps it is more like "This specification defines the following parameters, other parameters may be used and implementations MUST ignore unrecognised parameters"?
The text was updated successfully, but these errors were encountered: