Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuer indication of PoP requirement in Credential Request. #89

Closed
cobward opened this issue Oct 19, 2023 · 1 comment
Closed

Issuer indication of PoP requirement in Credential Request. #89

cobward opened this issue Oct 19, 2023 · 1 comment
Labels

Comments

@cobward
Copy link
Contributor

cobward commented Oct 19, 2023

Apologies for the out-of-order PR-then-issue, I didn't realise an issue was required for raising a PR.

As stated in #87:

Currently a wallet has no way of knowing whether the issuing authority requires a proof of possession in the Credential Request. From my point of view there are two ways we can remedy this:

  1. Add a parameter in the credentials_supported issuer metadata object that indicates whether a PoP is required.
  2. Add some normative text which would require wallets to send a PoP if proof_types_supported in the credentials_supported issuer metadata object is not omitted and contains at least one element.

Personally I prefer explicit indication over implied so I have raised the PR showing option 1, but I am open to other opinions and options.

@Sakurann
Copy link
Collaborator

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants