code review fix

maerki · maerki · commit 4e5d0befd207 · 2024-11-04T17:16:54.000+01:00
Signed-off-by: Nicolas Märki &lt;maerki@ubique.ch&gt;
diff --git a/ios/graphics/Model/MultiBuffer.swift b/ios/graphics/Model/MultiBuffer.swift
@@ -38,11 +38,11 @@ public struct MultiBuffer<DataType> {
 extension MultiBuffer<simd_float1> {
     public init(device: MTLDevice) {
         var initialMutable = simd_float1(1.0)
-        var buffers: [MTLBuffer] = (0..<bufferCount).compactMap { _ in
+        let buffers: [MTLBuffer] = (0..<bufferCount).compactMap { _ in
             device
                 .makeBuffer(
                     bytes: &initialMutable,
-                    length: MemoryLayout<simd_float4x4>.stride
+                    length: MemoryLayout<simd_float1>.stride
                 )
         }
         self.init(buffers: buffers)
@@ -56,7 +56,7 @@ extension MultiBuffer<simd_float4> {
             device
                 .makeBuffer(
                     bytes: &initialMutable,
-                    length: MemoryLayout<simd_float4x4>.stride
+                    length: MemoryLayout<simd_float4>.stride
                 )
         }
         self.init(buffers: buffers)

Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,11 @@ public struct MultiBuffer<DataType> {`
`38`	`38`	`extension MultiBuffer<simd_float1> {`
`39`	`39`	`public init(device: MTLDevice) {`
`40`	`40`	`var initialMutable = simd_float1(1.0)`
`41`		`- var buffers: [MTLBuffer] = (0..<bufferCount).compactMap { _ in`
	`41`	`+ let buffers: [MTLBuffer] = (0..<bufferCount).compactMap { _ in`
`42`	`42`	`device`
`43`	`43`	`.makeBuffer(`
`44`	`44`	`bytes: &initialMutable,`
`45`		`- length: MemoryLayout<simd_float4x4>.stride`
	`45`	`+ length: MemoryLayout<simd_float1>.stride`
`46`	`46`	`)`
`47`	`47`	`}`
`48`	`48`	`self.init(buffers: buffers)`
`@@ -56,7 +56,7 @@ extension MultiBuffer<simd_float4> {`
`56`	`56`	`device`
`57`	`57`	`.makeBuffer(`
`58`	`58`	`bytes: &initialMutable,`
`59`		`- length: MemoryLayout<simd_float4x4>.stride`
	`59`	`+ length: MemoryLayout<simd_float4>.stride`
`60`	`60`	`)`
`61`	`61`	`}`
`62`	`62`	`self.init(buffers: buffers)`