Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] OpenSearchISMPolicy.applyToExistingIndices #828

Open
cthtrifork opened this issue May 27, 2024 · 2 comments
Open

[PROPOSAL] OpenSearchISMPolicy.applyToExistingIndices #828

cthtrifork opened this issue May 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@cthtrifork
Copy link
Contributor

What/Why

What are you proposing?

In a few sentences, describe the feature and its core capabilities.

We are considering a design where a applyToExistingIndices is added to the OpenSearchISMPolicy api/CRD.

If true, this will the policy to all existing indices matching the index pattern of the template.

What problems are you trying to solve?

We would like to avoid having to rely on "database administrators" as much as possible and going in the GitOps direction. Right now I do not see a way of applying a policy to any existing indices.

Are there any security considerations?

I am not sure I understand all the dataflows related to ISM policies. It seems like state and other metadata is stored outside the index, so I am unsure of the riscs involved in adding this flag.

What will it take to execute?

We would be willing to make a PR for this feature, if is no major concerns.
We would add it to the reconciler logic for ISM policies and ensure that we call the update policy API endpoint in the gateway using the index pattern supplied in the ISM policy.

@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label May 27, 2024
@cthtrifork
Copy link
Contributor Author

https://opensearch.org/docs/latest/im-plugin/ism/api/#add-policy

Adds a policy to an index. This operation does not change the policy if the index already has one.

@swoehrl-mw
Copy link
Collaborator

Hi @cthtrifork. Adding this feature is fine by me. I don't have a real concerns.

Implementation-wise the reconciler should do this apply only when the policy is first created or the pattern is changed.

@swoehrl-mw swoehrl-mw added enhancement New feature or request and removed untriaged Issues that have not yet been triaged labels Jun 5, 2024
@getsaurabh02 getsaurabh02 moved this from 🆕 New to Backlog in Engineering Effectiveness Board Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📦 Backlog
Development

No branches or pull requests

2 participants