Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shop or amenity remove layer=1 from building=roof #1439

Closed
Oivo35 opened this issue Feb 8, 2025 · 5 comments
Closed

Shop or amenity remove layer=1 from building=roof #1439

Oivo35 opened this issue Feb 8, 2025 · 5 comments
Labels
invalid This doesn't seem right

Comments

@Oivo35
Copy link

Oivo35 commented Feb 8, 2025

  1. original tagging of area is
    building=roof + layer=1

  2. after adding shop or amenity from search menu, layer=1 tag is removed
@Oivo35 Oivo35 added bug Something isn't working needs-triage This is a fresh issue which has not yet been looked over by the maintainers of this repository. labels Feb 8, 2025
@Oivo35 Oivo35 changed the title Shop or amenity removes layer=1 from building=roof Shop or amenity remove layer=1 from building=roof Feb 8, 2025
@tordans
Copy link
Collaborator

tordans commented Feb 8, 2025

This sounds like a duplicate of #1404 , right?

@Oivo35
Copy link
Author

Oivo35 commented Feb 8, 2025

In this case after adding shop or amenity only layer=1 is removed, building=roof tag is preserved.

@Avan2021

This comment has been minimized.

Sign in to view
@tyrasd
Copy link
Member

tyrasd commented Feb 18, 2025

Wait… what kind of shop/amenity exists that is also a roof? 😅 If anything, the bug here is that in this operation the building=roof tag is not removed. But as the tag value is well visible in the building field, it can be fixed by the user accordingly after the preset switch.

@tyrasd tyrasd closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2025
@tyrasd tyrasd added invalid This doesn't seem right and removed bug Something isn't working needs-triage This is a fresh issue which has not yet been looked over by the maintainers of this repository. labels Feb 18, 2025
@Oivo35
Copy link
Author

Oivo35 commented Feb 18, 2025

@tyrasd
Building=roof is often tagged together with amenity=fuel. According to taginfo, there are 79,000 objects with this combination.
Of course, you can manually add the layer=1 tag again, but why make things harder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tordans @tyrasd @Oivo35 @Avan2021