Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge=aqueduct is missing from the structure preset of waterway #1464

Open
SteveLz opened this issue Aug 4, 2024 · 4 comments · May be fixed by #1273
Open

bridge=aqueduct is missing from the structure preset of waterway #1464

SteveLz opened this issue Aug 4, 2024 · 4 comments · May be fixed by #1273
Labels

Comments

@SteveLz
Copy link
Contributor

SteveLz commented Aug 4, 2024

Description

There are tunnels but no bridge (aqueduct) in the structure of the waterway preset.
taginfo

Screenshots

No response

@Avan2021
Copy link
Contributor

Avan2021 commented Feb 3, 2025

Can you tell me a little more about this issue? It is related to presets, so wouldn't it be better to move it to the id-tagging-schema repo since that repo is for presets for OSM?

@tyrasd tyrasd transferred this issue from openstreetmap/iD Feb 25, 2025
@tyrasd tyrasd added the field label Feb 25, 2025
@tyrasd
Copy link
Member

tyrasd commented Feb 25, 2025

the relevant file is structure_waterway.json

@SteveLz
Copy link
Contributor Author

SteveLz commented Feb 25, 2025

the relevant file is structure_waterway.json

Changed in #1273, but selecting bridge on a canal does not seem to automatically set aqueduct like selecting tunnel automatically sets culvert. The relevant code should be here, right?
By the way, is it possible to embed bridge:name and tunnel:name in structure? It may be better than separate field boxes.

@tyrasd
Copy link
Member

tyrasd commented Feb 26, 2025

yep, automatically setting aqueduct makes sense for waterways (similar to how tunnel is defaulting to culvert), and it needs to be implemented in iD's code.

By the way, is it possible to embed bridge:name and tunnel:name in structure?

Possible yes, but especially for the multilingual name field, the UI would be quite tricky to implement and work well. I'd say the approach in #1273 is good enough for the moment.

@tyrasd tyrasd linked a pull request Feb 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants