Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both string and JSON encoded variant of presentation_definition and dcql_query #17

Closed
TimoGlastra opened this issue Jan 23, 2025 · 2 comments
Labels

Comments

@TimoGlastra
Copy link
Contributor

TimoGlastra commented Jan 23, 2025

An issue we've ran into with the DCQL implementation from the PR in credo is that it encodes the dcql_query as string. For presentation_definition it encodes it as JSON object when doing JAR.

I think the agreement for OID4VP is to use string when encoding as url query, but if using JAR we can keep it as json. When parsing we should support both to increate interoperability.

See openid/OpenID4VP#378

@auer-martin could you take this into account with the oid4vp impementation?

@TimoGlastra TimoGlastra changed the title Support both string and JSON encoded variant of presentation_definition and dcql_query [OID4VP] Support both string and JSON encoded variant of presentation_definition and dcql_query Feb 6, 2025
@TimoGlastra TimoGlastra changed the title [OID4VP] Support both string and JSON encoded variant of presentation_definition and dcql_query Support both string and JSON encoded variant of presentation_definition and dcql_query Feb 6, 2025
@TimoGlastra
Copy link
Contributor Author

Update: openid/OpenID4VP#422

@TimoGlastra
Copy link
Contributor Author

Fixed in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant