-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zimit2: Youtube videos are not playing (found at least in mesquartierschinois and 100rabbits) #149
Comments
This is strange. The video exists in the zim file ( I'm investigating. |
Nota: I've updated the recipe |
I corroborate this -- I've seen it often while testing support for zimit2 in Kiwix JS and Kiwix PWA (that video is usually not working). A small example is in the 100 rabbits zimit2 file from 2024-01, article "Orca". I'm seeing a bunch of POST failures in console log on Kiwix PWA (see bottom right of screenshot below). I don't know if that's related. There is a December version of the same archive using zimit classic, where the video plays fine (in the PWA or KJS Browser Extension). These two small ZIMs ("Orca" article) might make a useful test case for comparison. The main difference is that when running in zimit classic, there are console messages saying "Attempting to resolve fuzzy headers for url...", whereas I don't see any such message in the zimit2 implementation. In my old implementation where I did the fuzzy search in the reader, it tells me that it transformed the requested URL (in the zimit classic version) into this monster in order to get the MP4:
|
Since the 100rabbits file (https://master.download.kiwix.org/zim/.hidden/dev/100rabbits_en_2024-01.zim) "orca" article video displays the exact same symptoms as |
Thank you @Jaifroid for finding the "Orca" issue. |
It appears we should apply the same transformation as https://github.com/webrecorder/wabac.js/blob/main/src/rewrite/dsruleset.js I will make a PR to add it. |
Fixed by #158 |
Page: https://dev.library.kiwix.org/viewer#mes-quartiers-chinois_fr_all_2024-01/mesquartierschinois.wordpress.com/2014/07/17/girona-menamora/
When you try to play the youtube video on this page, the video never starts.
The text was updated successfully, but these errors were encountered: