Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement galleries #4212

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Implement galleries #4212

merged 5 commits into from
Feb 11, 2025

Conversation

casey
Copy link
Collaborator

@casey casey commented Feb 7, 2025

Fixes #4140.

@casey casey marked this pull request as draft February 8, 2025 00:31
@raphjaph raphjaph marked this pull request as ready for review February 11, 2025 19:55
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph
Copy link
Collaborator

Think about naming gallery something else.

Also tests are failing.

@casey casey enabled auto-merge (squash) February 11, 2025 23:34
@casey casey merged commit cd64012 into ordinals:master Feb 11, 2025
5 checks passed
@casey casey deleted the gallery branch February 12, 2025 00:02
@casey casey mentioned this pull request Feb 12, 2025
@stet
Copy link

stet commented Feb 12, 2025

Think about naming gallery something else.

Also tests are failing.

They are actually curated onchain exhibits. Many exhibits can be in a "gallery" which would be an external presentation layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Galleries and legacy collections
3 participants