-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] different color detection on mobile browser vs desktop #51
Comments
I opened an issue on node-vibrant: Vibrant-Colors/node-vibrant#132 |
I ultimately decided to call the function from a server to always get consistent results. Bummer cause it's slower, but it works that way. |
I do wish to explore if this library could be re-written to wrap another C++ library for image color extraction using JSI and WASM for web. I think this is the last resort to unify results for all platforms. Just need to find the time since I have no experience with all of that and would have to explore if its doable. |
If anyone takes this on, I will be happy to add them as a maintainer of |
Bug
Mobile browsers and desktop browsers return a different set of colors for the same image. I'm not sure if this is a bug with
node-vibrant
or this library's Web approach. My guess is it's node vibrant?Take this image:
On a desktop browser, I get these colors, which seem relatively correct. They're essentially grays.
However, on a mobile browser (Chrome or Safari on iOS), I get these colors:
Environment info
Steps To Reproduce
Describe what you expected to happen:
Reproducible sample code
Here is a reproducible snack: https://snack.expo.dev/@beatgig/thankful-almond?supportedPlatforms=web
These are the colors it comes up with on a desktop browser:
Meanwhile, here it is on a mobile browser (you'll have to turn your phone sideways to see it on Snack)
The text was updated successfully, but these errors were encountered: