Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: full fetch even for js generated websites #58

Closed
Sanix-Darker opened this issue May 6, 2022 · 0 comments · Fixed by #67
Closed

feat: full fetch even for js generated websites #58

Sanix-Darker opened this issue May 6, 2022 · 0 comments · Fixed by #67

Comments

@Sanix-Darker
Copy link
Member

We should have these informations :

  • all the links tested
  • all the links succeeded
  • all the links failed

Asking this because some websites like osscameroon.com is built using React, therefore, the requests.get is not going to "load" the page and its links... just some small html and a div like

(as far as i can remember, didn't touch react since a long time) where the JS binding file is supposed to render the SPA.

PS: "NOT TESTED on my end", I may be wrong, but i think you should check the 'content' result you fetch from PWA.

How to deal with this ?
using a JScrawler... or if you want to don't change your actual code loggic, use requests_html is your way to go... (it will download a chromium binary that will be called to render pages in background).

Not sure i may available this night for a session of live coding, but feel free to share your questions here in the chat @pythonbrad !

Good job so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant