Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find "leaking" items in test execution #53

Open
m-Schlitzer opened this issue Mar 14, 2017 · 6 comments
Open

Find "leaking" items in test execution #53

m-Schlitzer opened this issue Mar 14, 2017 · 6 comments
Assignees

Comments

@m-Schlitzer
Copy link
Collaborator

As it is now, the items created on the server by the tests remain there and fill up the storage.
tear_down() should clean that up, which it only does with resources acquired by curl_global_init, by calling curl_global_cleanup().

@bkircher
Copy link
Collaborator

Maybe we can purge the entire mailbox, even remove it entirely in global tear-down and create a new one in global set-up?

@bkircher
Copy link
Collaborator

bkircher commented Mar 14, 2017

Well, OTOH, each individual test case should clean-up after itself. Can you figure out which test case does leave everything around and why?

@m-Schlitzer
Copy link
Collaborator Author

Will do and update when I know more. Wouldn't this have a high impact on the test performance?

@bkircher
Copy link
Collaborator

Wouldn't this have a high impact on test performance?

Why? All test cases clean-up in TearDown() methods already. And test execution is still okay, absolutely bearable, IMO.

@m-Schlitzer
Copy link
Collaborator Author

m-Schlitzer commented Mar 14, 2017

Since it's only tests it won't be too bad I suppose. The contacts and tasks that are created are the ones that remain on the server. I'll check out how I can clean them up with tear_down()

@bkircher
Copy link
Collaborator

I'll check out how I can clean them up with tear_down()

Thank you. Keep in mind to search for the test cases that create these items first. The items should be removed by the TearDown() method of the individual test case or using a on_scope_exit scope guard if they are not created in a SetUp().

Removing or cleaning-up the entire mailbox in a global tear-down should be done only when all else has failed.

@bkircher bkircher removed their assignment Mar 14, 2017
@bkircher bkircher changed the title Make tear_down() clean up the server Find "leaking" items in test execution Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants