Make ews-cpp build and run for Android NDK

[kmorrissey-mersive]

We would like to use ews-cpp on a device that runs Linux/Android. Android NDK C++ libraries do not have std::to_string() and a few other functions that ews-cpp counts on. I made some minor localized changes to ews-cpp to correct for the missing functions. How do I go about submitting the changes for consideration?

[bkircher]

Hi Karen!

Android support would be a great addition and I would definitely like to merge any changes in that direction.

How do I go about submitting the changes for consideration?

Well, just the normal "GitHub flow": Make sensible commits in a separate branch, publish that branch in your fork on GitHub, and, once you think its complete, open a new pull request.

You might want to check the contribution guide for more info.

[bkircher]

Would be nice if we could support Android NDK in our CI matrix. AFAIK, only Android SDK is supported in Travis CI builds.

[bkircher]

CircleCI apparently pre-installs Android NDK.

[kmorrissey-mersive]

I made a pull request with the Android NDK changes (plus a few others). I did something wrong in how I managed my repo/threads, and the pull request has some changes you should already have. You might not want to merge yet, because when looking at the pull changes, I see some things I may have done wrong. From: Benjamin Kircher [mailto:notifications@github.com] Sent: Tuesday, June 6, 2017 3:16 AM To: otris/ews-cpp <ews-cpp@noreply.github.com> Cc: Karen Morrissey <kmorrissey@mersive.com>; Author <author@noreply.github.com> Subject: Re: [otris/ews-cpp] Make ews-cpp build and run for Android NDK (#57) Hi Karen! Android support would be a great addition and I would definitely like to merge any changes in that direction. How do I go about submitting the changes for consideration? Well, just the normal "GitHub flow": Make sensible commits in a separate branch, publish that branch in your fork on GitHub, and, once you think its complete, open a pull request<https://help.github.com/articles/about-pull-requests/>. You might want to check the contribution guide<https://github.com/otris/ews-cpp/blob/master/CONTRIBUTING.md> for more info. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#57 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYIa0XhSo6rOZuo3Ku_djYn7OIoicjQbks5sBRjMgaJpZM4NvfDJ>.

[kmorrissey-mersive]

One thing I was trying to fix was that on Windows VC++ under VS2012 (which we are stuck using for now) min(a,b) and max(a,b) are macros unless NOMINMAX is #defined. I can imagine some people not wanting ews-cpp to require that NOMINMAX be defined, but I don’t know how else to do it. Do you have any thoughts? From: Benjamin Kircher [mailto:notifications@github.com] Sent: Tuesday, June 6, 2017 3:16 AM To: otris/ews-cpp <ews-cpp@noreply.github.com> Cc: Karen Morrissey <kmorrissey@mersive.com>; Author <author@noreply.github.com> Subject: Re: [otris/ews-cpp] Make ews-cpp build and run for Android NDK (#57) Hi Karen! Android support would be a great addition and I would definitely like to merge any changes in that direction. How do I go about submitting the changes for consideration? Well, just the normal "GitHub flow": Make sensible commits in a separate branch, publish that branch in your fork on GitHub, and, once you think its complete, open a pull request<https://help.github.com/articles/about-pull-requests/>. You might want to check the contribution guide<https://github.com/otris/ews-cpp/blob/master/CONTRIBUTING.md> for more info. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#57 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYIa0XhSo6rOZuo3Ku_djYn7OIoicjQbks5sBRjMgaJpZM4NvfDJ>.

[bkircher]

Seems like there is no libcurl for Android NDK.

[kmorrissey-mersive]

That’s not true. We use libcurl in Android NDK programs. I’m using ews-cpp right now under NDK. From: Benjamin Kircher [mailto:notifications@github.com] Sent: Friday, July 14, 2017 8:57 AM To: otris/ews-cpp <ews-cpp@noreply.github.com> Cc: Karen Morrissey <kmorrissey@mersive.com>; Author <author@noreply.github.com> Subject: Re: [otris/ews-cpp] Make ews-cpp build and run for Android NDK (#57) Seems like there is no libcurl for Android NDK. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#57 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYIa0eDX2skY_dQts8C6eJxkR5WfMAMVks5sN4GtgaJpZM4NvfDJ>.

[bkircher]

That’s not true. We use libcurl in Android NDK programs. I’m using ews-cpp right now under NDK.

You're probably absolutely right. I'm totally new to Android.

[kmorrissey-mersive]

We have been running with a private, modified copy of EWS-CPP in our product. Didn't do it right the first time, so we have fallen far behind in keeping up with EWS-CPP changes. We are now setting up a proper fork and will reintegrate our Android NDK changes so we can do a usable pull request. We will be another customer for OAuth; a lot of our users use our product to access O365.

[bkircher]

Cool. Awesome news!

[idolum]

@kmorrissey-mersive Did you made progress with the Android NDK integration? Did the changes for OAuth2 work for you? I realized that there needs more to be done, if the client sits behind a proxy (see #172).