Make essay removal completely manual

Keep essays of people who organizer mark their applications for
rejection.

When reviewing initial applications, I have accidentally hit the 'reject
application' button when I meant to click another button. That means the
essay is automatically purged from our database, and that application
essay is lost.

Instead, make purging essays a manual process that is done once all
applications have been reviewed and finalized.

Update the test to manually remove sensitive information for rejected
applications as well as approved applications.

Author: Sage Sharp

home/test_privacy_initial_application_sensitive_data.py

@@ -257,15 +257,16 @@ def test_sensitive_data_removed_on_processing(self):
 
                 if approval_status == models.ApprovalStatus.APPROVED:
                     response = self.client.post(applicant_approval.get_approve_url())
-                    # Reload the object from the database after the invoked view modifies the database
-                    applicant_approval = models.ApplicantApproval.objects.get(pk=applicant_approval.pk)
-
-                    # Manually collect statistics and purge essay
-                    applicant_approval.collect_statistics()
-                    applicant_approval.purge_sensitive_data()
                 elif approval_status == models.ApprovalStatus.REJECTED:
                     response = self.client.post(applicant_approval.get_reject_url())
 
+                # Reload the object from the database after the invoked view modifies the database
+                applicant_approval = models.ApplicantApproval.objects.get(pk=applicant_approval.pk)
+
+                # Manually collect statistics and purge essay
+                applicant_approval.collect_statistics()
+                applicant_approval.purge_sensitive_data()
+
                 self.assertRedirects(response, applicant_approval.get_preview_url())
 
                 # Reload the object from the database after the invoked view modifies the database

home/views.py

@@ -4072,17 +4072,8 @@ def get_object(self):
                 application_round=current_round)
 
     def get_success_url(self):
-        # If the ApplicantApproval was just rejected
-        # collect aggregate anonymized statistics and delete:
-        # - essay answers
-        # - gender identity data
-        # - race and ethnicity demographics
-        if self.object.approval_status == ApprovalStatus.REJECTED:
-            self.object.collect_statistics()
-            self.object.purge_sensitive_data()
-
         # Outreachy organizers will manually collect statistics
-        # and purge essays of approved applications
+        # and purge application essays and sensitive information
 
         return self.object.get_preview_url()