From 74b0a392187bc5520ee84ac3d2968e3e08325c1f Mon Sep 17 00:00:00 2001 From: Danyal-Faheem Date: Thu, 12 Dec 2024 18:40:22 +0500 Subject: [PATCH] fix: remove extra '%' from LTI_DEFAULT_JUPYTER_HUB_URL --- changelog.d/20241212_183857_danyal.faheem_fix_base_url.md | 1 + tutorjupyter/patches/openedx-common-settings | 2 +- tutorjupyter/patches/openedx-development-settings | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changelog.d/20241212_183857_danyal.faheem_fix_base_url.md diff --git a/changelog.d/20241212_183857_danyal.faheem_fix_base_url.md b/changelog.d/20241212_183857_danyal.faheem_fix_base_url.md new file mode 100644 index 0000000..5a58424 --- /dev/null +++ b/changelog.d/20241212_183857_danyal.faheem_fix_base_url.md @@ -0,0 +1 @@ +- [Bugfix] Fix the LTI_DEFAULT_JUPYTER_HUB_URL which had an extra '%' in the HTTPS URL. (by @Danyal-Faheem) \ No newline at end of file diff --git a/tutorjupyter/patches/openedx-common-settings b/tutorjupyter/patches/openedx-common-settings index 09923c3..cf41c3c 100644 --- a/tutorjupyter/patches/openedx-common-settings +++ b/tutorjupyter/patches/openedx-common-settings @@ -1,3 +1,3 @@ # Jupyter XBlock LTI_DEFAULT_JUPYTER_PASSPORT_ID = "{{ JUPYTER_DEFAULT_PASSPORT_ID }}" -LTI_DEFAULT_JUPYTER_HUB_URL = "{% if ENABLE_HTTPS %}%https{% else %}http{% endif %}://{{ JUPYTER_HOST }}" +LTI_DEFAULT_JUPYTER_HUB_URL = "{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ JUPYTER_HOST }}" diff --git a/tutorjupyter/patches/openedx-development-settings b/tutorjupyter/patches/openedx-development-settings index 9f45079..a345181 100644 --- a/tutorjupyter/patches/openedx-development-settings +++ b/tutorjupyter/patches/openedx-development-settings @@ -1,3 +1,3 @@ LTI_DEFAULT_JUPYTER_PASSPORT_ID = "{{ JUPYTER_DEFAULT_PASSPORT_ID }}" -LTI_DEFAULT_JUPYTER_HUB_URL = "{% if ENABLE_HTTPS %}%https{% else %}http{% endif %}://{{ JUPYTER_HOST }}:9045" +LTI_DEFAULT_JUPYTER_HUB_URL = "{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ JUPYTER_HOST }}:9045"