Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graded download issues #43

Closed
CodeWithEmad opened this issue Jul 11, 2024 · 1 comment
Closed

Graded download issues #43

CodeWithEmad opened this issue Jul 11, 2024 · 1 comment

Comments

@CodeWithEmad
Copy link
Member

This is a duplicate of hastexo/tutor-contrib-s3#77

Hi. I noticed a couple of issues related to GRADES_DOWNLOAD.
There's a section in the instructor tab of each course, where instructors can download grades in a CSV format.
Inside lms/djangoapps/instructor_task/models.py, where we create a DjangoStorageReportStore, it needs these values from the config, otherwise will fail:

  • STORAGE_TYPE
  • BUCKET
  • ROOT_PATH
  • CUSTOM_DOMAIN (if exists)

https://github.com/openedx/edx-platform/blob/f3f160f4f20f7bbde45fe0d48ac9626a694afb93/lms/djangoapps/instructor_task/models.py#L230-L242

Oddly, it's not reading them from AWS_S3_ configs.

In the plugin, just a bucket_name and a location kwargs are overridden.

GRADES_DOWNLOAD["STORAGE_KWARGS"] = {"location": GRADES_DOWNLOAD["STORAGE_KWARGS"]["location"].lstrip("/")}
GRADES_DOWNLOAD["STORAGE_KWARGS"]["bucket_name"] = "{{ S3_GRADE_BUCKET }}"

Note that I didn't use the plugin, but just used GRADES_DOWNLOAD config mentioned above and it didn't work.
If this is a valid issue, I would like to work on it.

@DawoudSheraz
Copy link
Contributor

@FahadKhalid210 FYI

@DawoudSheraz DawoudSheraz moved this from Pending Triage to Backlog in Tutor project management Jul 12, 2024
@DawoudSheraz DawoudSheraz moved this from Backlog to In review in Tutor project management Jul 26, 2024
@DawoudSheraz DawoudSheraz moved this from In review to Won't fix in Tutor project management Jul 30, 2024
@DawoudSheraz DawoudSheraz closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
@github-project-automation github-project-automation bot moved this from Won't fix to Done in Tutor project management Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants