Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit the test suite #407

Open
jkowalleck opened this issue Mar 6, 2025 · 0 comments · May be fixed by #409
Open

revisit the test suite #407

jkowalleck opened this issue Mar 6, 2025 · 0 comments · May be fixed by #409
Assignees
@jkowalleck
Labels
Test suite

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Mar 6, 2025 •
edited
Loading

the test suite has four targets/scenarios today:

purl-spec/PURL-SPECIFICATION.rst

Lines 473 to 485 in 65d98c4

To test ``purl`` parsing and building, a tool can use this test suite and for
every listed test object, run these tests:
- parsing the test canonical ``purl`` then re-building a ``purl`` from these parsed
components should return the test canonical ``purl``
- parsing the test ``purl`` should return the components parsed from the test
canonical ``purl``
- parsing the test ``purl`` then re-building a ``purl`` from these parsed components
should return the test canonical ``purl``
- building a ``purl`` from the test components should return the test canonical ``purl``

discussions in multiple issues & pull requests showed, that the test cases did not properly adhere to their own cases.

  • for some cases, the components are normalized/canonicalized, where the purl was not - which would just take some targets/scenarios away
  • for some cases, the is_invalid was true, where actually all tests were expected to pass for all targets/scenarios
  • ... to be continued ...

this shall be fixed.
@jkowalleck jkowalleck self-assigned this Mar 6, 2025
jkowalleck added a commit to jkowalleck/fork_purl-spec that referenced this issue Mar 6, 2025
@jkowalleck
fix package-url#407
66ff905 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit to jkowalleck/fork_purl-spec that referenced this issue Mar 6, 2025
@jkowalleck
revisit the test suite
be3db57 
fix package-url#407

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit to jkowalleck/fork_purl-spec that referenced this issue Mar 6, 2025
@jkowalleck
revisit test-suite
077166e 
fixes package-url#407

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck linked a pull request Mar 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
Test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revisit test-suite jkowalleck/fork_purl-spec
1 participant
@jkowalleck