Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for basic authentification #2

Open
p3l1 opened this issue Jan 7, 2022 · 2 comments
Open

Adding support for basic authentification #2

p3l1 opened this issue Jan 7, 2022 · 2 comments

Comments

@p3l1
Copy link

p3l1 commented Jan 7, 2022

I am planning to use the acme-dns service behind an nginx reverse proxy with basic authentification, so the api is not exposed on the internet directly.

Because there will be many clients using the api, switching the /register endpoint on and off is not a sufficient solution for my usecase.

Would you accept a PR for this feature?

@mbag
Copy link
Member

mbag commented Jan 8, 2022

Hi @p3l1 , yes I/we will accept the PR for this feature.

@ZPascal
Copy link

ZPascal commented Jan 8, 2022

@p3l1 Good idea. After the implementation of the new feature, I can remove my custom validation script, the --manual-auth-hook call inside certbot certonly --manual-public-ip-logging-ok --manual --manual-auth-hook /srv/test/acme-dns-client.py --preferred-challenges=dns --email webmaster@test.com --server https://acme-v02.api.letsencrypt.org/directory --agree-tos -d ...... command and directly using the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants