Merge branch 'main' of github.com:panphp/pan

Author: nunomaduro

README.md

@@ -57,6 +57,9 @@ Finally, you may start tracking your pages or components adding the `data-pan` a
 </div>
 ```
 
+> [!IMPORTANT]  
+> Event names must only contain letters, numbers, dashes, and underscores.
+
 ## Visualize your product analytics
 
 To visualize your product analytics, you may use the `pan` Artisan command:

src/Adapters/Laravel/Http/Requests/CreateEventRequest.php

@@ -22,7 +22,7 @@ public function rules(): array
     {
         return [
             'events' => ['required', 'array'],
-            'events.*.name' => ['required', 'string', 'regex:/^[A-Za-z0-9-_]+$/'],
+            'events.*.name' => ['required', 'string', 'alpha_dash:ascii'],
             'events.*.type' => ['required', Rule::enum(EventType::class)],
         ];
     }

tests/Feature/Laravel/Http/EventsTest.php

@@ -79,6 +79,28 @@
     ]);
 });
 
+it('does not create an analytic event if the event name is invalid', function (string $name): void {
+    $response = $this->post('/pan/events', [
+        'events' => [[
+            'name' => $name,
+            'type' => 'impression',
+        ]],
+    ]);
+
+    $response->assertStatus(302)->assertSessionHasErrors([
+        'events.0.name' => 'The events.0.name field must only contain letters, numbers, dashes, and underscores.',
+    ]);
+
+    $analytics = array_map(fn (Analytic $analytic): array => $analytic->toArray(), app(AnalyticsRepository::class)->all());
+
+    expect($analytics)->toBe([]);
+})->with([
+    'help modal',
+    'help.modal',
+    'help/modal',
+    '🙋',
+]);
+
 it('does not create an analytic event if the event is invalid', function (): void {
     $response = $this->post('/pan/events', [
         'events' => [[