transfer function Preservation is changed to Expendable #7243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscoaguirre
approved these changes
Jan 20, 2025
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
|
Review required! Latest push from author must always be reviewed |
franciscoaguirre
approved these changes
Jan 30, 2025
acatangiu
approved these changes
Jan 31, 2025
bkontur
approved these changes
Jan 31, 2025
|
@dhirajs0 You have some clippy warnings. You can check them out in the CI jobs that failed in order to fix them |
github-actions
bot
requested review from
acatangiu,
bkontur and
franciscoaguirre
|
@franciscoaguirre I have fixed the cause of the clippy warnings. |
…//github.com/dhirajs0/polkadot-sdk into dhirajs0-TransferAsset-changed-to-Expandable
raymondkfcheung
approved these changes
Feb 3, 2025
|
/cmd fmt |
|
Command "fit" has started 🚀 See logs here |
raymondkfcheung
approved these changes
Feb 3, 2025
|
Command "fit" has failed ❌! See logs here |
|
@franciscoaguirre
|
franciscoaguirre
approved these changes
Feb 6, 2025
acatangiu
reviewed
Feb 10, 2025
Co-authored-by: Adrian Catangiu <adrian@parity.io>
auto-merge was automatically disabled
February 10, 2025 11:04
Head branch was pushed to by a user without write access
github-actions
bot
requested review from
acatangiu,
franciscoaguirre and
raymondkfcheung
acatangiu
added
the
A4-needs-backport
acatangiu
approved these changes
Feb 10, 2025
raymondkfcheung
approved these changes
Feb 10, 2025
Merged
via the queue into
paritytech:master
with commit Feb 10, 2025
f96da6f
231 of 274 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
# Description Fixes #7039 The Preservation of transfer method of fungible and fungibles adapters is changed from Preserve to Expendable. So the behavior of the TransferAsset will be consistent with the WithdrawAsset function, as in [fungible](https://github.com/paritytech/polkadot-sdk/blob/f3ab3854e1df9e0498599f01ba4f9f152426432a/polkadot/xcm/xcm-builder/src/fungible_adapter.rs#L217) and [fungibles](https://github.com/paritytech/polkadot-sdk/issues/url) adapter. This pull request includes changes to the `fungible_adapter.rs` and `fungibles_adapter.rs` files in the `polkadot/xcm/xcm-builder` directory. The main change involves modifying the transfer method to use the `Expendable` strategy instead of the `Preserve` strategy. Changes to transfer strategy: * [`polkadot/xcm/xcm-builder/src/fungible_adapter.rs`](diffhunk://#diff-6ebd77385441f2c8b023c480e818a01c4b43ae892c73ca30144cd64ee960bd66L67-R67): Changed the transfer method to use `Expendable` instead of `Preserve`. * [`polkadot/xcm/xcm-builder/src/fungibles_adapter.rs`](diffhunk://#diff-82221429de4c4c88be3d2976ece6475ef4fa56a32abc70290911bd47191f8e17L61-R61): Changed the transfer method to use `Expendable` instead of `Preserve`. --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> (cherry picked from commit f96da6f)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
# Description Fixes #7039 The Preservation of transfer method of fungible and fungibles adapters is changed from Preserve to Expendable. So the behavior of the TransferAsset will be consistent with the WithdrawAsset function, as in [fungible](https://github.com/paritytech/polkadot-sdk/blob/f3ab3854e1df9e0498599f01ba4f9f152426432a/polkadot/xcm/xcm-builder/src/fungible_adapter.rs#L217) and [fungibles](https://github.com/paritytech/polkadot-sdk/issues/url) adapter. This pull request includes changes to the `fungible_adapter.rs` and `fungibles_adapter.rs` files in the `polkadot/xcm/xcm-builder` directory. The main change involves modifying the transfer method to use the `Expendable` strategy instead of the `Preserve` strategy. Changes to transfer strategy: * [`polkadot/xcm/xcm-builder/src/fungible_adapter.rs`](diffhunk://#diff-6ebd77385441f2c8b023c480e818a01c4b43ae892c73ca30144cd64ee960bd66L67-R67): Changed the transfer method to use `Expendable` instead of `Preserve`. * [`polkadot/xcm/xcm-builder/src/fungibles_adapter.rs`](diffhunk://#diff-82221429de4c4c88be3d2976ece6475ef4fa56a32abc70290911bd47191f8e17L61-R61): Changed the transfer method to use `Expendable` instead of `Preserve`. --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> (cherry picked from commit f96da6f)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
# Description Fixes #7039 The Preservation of transfer method of fungible and fungibles adapters is changed from Preserve to Expendable. So the behavior of the TransferAsset will be consistent with the WithdrawAsset function, as in [fungible](https://github.com/paritytech/polkadot-sdk/blob/f3ab3854e1df9e0498599f01ba4f9f152426432a/polkadot/xcm/xcm-builder/src/fungible_adapter.rs#L217) and [fungibles](https://github.com/paritytech/polkadot-sdk/issues/url) adapter. This pull request includes changes to the `fungible_adapter.rs` and `fungibles_adapter.rs` files in the `polkadot/xcm/xcm-builder` directory. The main change involves modifying the transfer method to use the `Expendable` strategy instead of the `Preserve` strategy. Changes to transfer strategy: * [`polkadot/xcm/xcm-builder/src/fungible_adapter.rs`](diffhunk://#diff-6ebd77385441f2c8b023c480e818a01c4b43ae892c73ca30144cd64ee960bd66L67-R67): Changed the transfer method to use `Expendable` instead of `Preserve`. * [`polkadot/xcm/xcm-builder/src/fungibles_adapter.rs`](diffhunk://#diff-82221429de4c4c88be3d2976ece6475ef4fa56a32abc70290911bd47191f8e17L61-R61): Changed the transfer method to use `Expendable` instead of `Preserve`. --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> (cherry picked from commit f96da6f)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 11, 2025
Backport #7243 into `stable2409` from dhirajs0. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Dhiraj Sah <dhiraj.kumar2990@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7039
The Preservation of transfer method of fungible and fungibles adapters is changed from Preserve to Expendable. So the behavior of the TransferAsset will be consistent with the WithdrawAsset function, as in fungible and fungibles adapter.
This pull request includes changes to the
fungible_adapter.rsandfungibles_adapter.rsfiles in thepolkadot/xcm/xcm-builderdirectory. The main change involves modifying the transfer method to use theExpendablestrategy instead of thePreservestrategy.Changes to transfer strategy:
polkadot/xcm/xcm-builder/src/fungible_adapter.rs: Changed the transfer method to useExpendableinstead ofPreserve.polkadot/xcm/xcm-builder/src/fungibles_adapter.rs: Changed the transfer method to useExpendableinstead ofPreserve.