Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warmup SharedTrieCache at startup #7533

Open
alexggh opened this issue Feb 11, 2025 · 2 comments
Open

Warmup SharedTrieCache at startup #7533

alexggh opened this issue Feb 11, 2025 · 2 comments
Assignees

Comments

@alexggh
Copy link
Contributor

alexggh commented Feb 11, 2025

Add logic at the node level, that based on the runtime configuration/maybe cli flag, decides that entire state needs to fit into memory, warms up the SharedTrieCache and performs some sanity checks to confirm memory usage is within reasonable bounds.

In case memory is insufficient or we are running low on it the node should abort graciously.

@bkchr
Copy link
Member

bkchr commented Feb 11, 2025

Add logic at the collator level

Just general node level.

Not sure we need some sanity checks. As we read the state, we could warn when we see that the memory usage is too high or abort "nicely".

@alexggh alexggh changed the title Collator warmup SharedTrieCache at startup Warmup SharedTrieCache at startup Feb 11, 2025
@alexggh
Copy link
Contributor Author

alexggh commented Feb 11, 2025

Not sure we need some sanity checks. As we read the state, we could warn when we see that the memory usage is too high or abort "nicely".

Yes, the end result should be either the node succeeded warming the SharedTrieCache and the spare memory is still in some reasonable bounds and if either can't fit the entire state into the SharedTrieCache or if it is running low on memory post warming it should abort nicely.

Updated the description to make it more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants