From b8120879e1a24238de147c604ef7f3061746cbc7 Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Thu, 9 Jan 2025 18:16:51 +0000
Subject: [PATCH] MDL-84148 tool_lp: clarify the primary save action of scales
 dialogue.

---
 admin/tool/lp/templates/scale_configuration_page.mustache | 2 +-
 admin/tool/lp/tests/behat/framework_crud.feature          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/admin/tool/lp/templates/scale_configuration_page.mustache b/admin/tool/lp/templates/scale_configuration_page.mustache
index 2ccf87968cd12..7f0b55df7ddc5 100644
--- a/admin/tool/lp/templates/scale_configuration_page.mustache
+++ b/admin/tool/lp/templates/scale_configuration_page.mustache
@@ -59,7 +59,7 @@
 </div>
 
 <div data-region="scale-buttons" class="mt-1 float-sm-right">
-    <input type="button" class="btn btn-secondary" data-action="close" value="{{#str}}closebuttontitle{{/str}}"/>
     <input type="button" class="btn btn-secondary" data-action="cancel" value="{{#str}}cancel{{/str}}"/>
+    <input type="button" class="btn btn-primary" data-action="close" value="{{#str}}save{{/str}}"/>
 </div>
 <div class="clearfix"></div>
diff --git a/admin/tool/lp/tests/behat/framework_crud.feature b/admin/tool/lp/tests/behat/framework_crud.feature
index 792808b0940e9..584b025a92f9c 100644
--- a/admin/tool/lp/tests/behat/framework_crud.feature
+++ b/admin/tool/lp/tests/behat/framework_crud.feature
@@ -23,7 +23,7 @@ Feature: Manage competency frameworks
     And I press "Configure scales"
     And I click on "//input[@data-field='tool_lp_scale_default_1']" "xpath_element"
     And I click on "//input[@data-field='tool_lp_scale_proficient_1']" "xpath_element"
-    And I click on "//input[@value='Close']" "xpath_element"
+    And I click on "Save" "button" in the "Default competence scale" "dialogue"
     When I press "Save changes"
     Then I should see "Competency framework created"
     And I should see "Science Year-1"