Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library has a production dependency to react and react-dom #13

Open
charbugs opened this issue Apr 24, 2019 · 0 comments · May be fixed by #14
Open

Library has a production dependency to react and react-dom #13

charbugs opened this issue Apr 24, 2019 · 0 comments · May be fixed by #14

Comments

@charbugs
Copy link

Hi,
is it possible to specify react and react-dom as dev dependencies? Otherwise installing react-iframe-comm will result in installing react too, what may lead to some issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move react/react-dom to dev and peer dependencies mejackreed/react-iframe-comm
1 participant
@charbugs