Skip to content

Commit e0edc02

Browse files
committed
I believe this fixes perfsonar/toolkit#475. Previopusly was only looking in /etc/hosts if name existed. Now combines all sources.
1 parent d1e9fd7 commit e0edc02

File tree

1 file changed

+33
-36
lines changed
  • psconfig/perfsonar-psconfig/psconfig/utilities

1 file changed

+33
-36
lines changed

psconfig/perfsonar-psconfig/psconfig/utilities/dns.py

+33-36
Original file line numberDiff line numberDiff line change
@@ -71,33 +71,31 @@ def resolve_address_multi(addresses, timeout=60):
7171
for address in addresses:
7272
#try /etc/hosts first
7373
ip_hosts, host_ips = read_etc_hosts()
74-
7574
if address in host_ips:
7675
results[address] = results.get(address, [])
7776
results[address] += host_ips[address]
78-
79-
else:
80-
#v4 lookup
81-
try:
82-
v4_result = res.resolve(address, 'A')
83-
if v4_result:
84-
results[address] = results.get(address, [])
85-
for result in v4_result:
86-
results[address].append(result.to_text())
87-
except Exception as e:
88-
#can not resolve #####add logging
89-
pass
90-
91-
#v6 lookup
92-
try:
93-
v6_result = res.resolve(address, 'AAAA')
94-
if v6_result:
95-
results[address] = results.get(address, [])
96-
for result in v6_result:
97-
results[address].append(result.to_text())
98-
except Exception as e:
99-
#can not resolve #####add logging
100-
pass
77+
78+
#v4 lookup
79+
try:
80+
v4_result = res.resolve(address, 'A')
81+
if v4_result:
82+
results[address] = results.get(address, [])
83+
for result in v4_result:
84+
results[address].append(result.to_text())
85+
except Exception as e:
86+
#can not resolve #####add logging
87+
pass
88+
89+
#v6 lookup
90+
try:
91+
v6_result = res.resolve(address, 'AAAA')
92+
if v6_result:
93+
results[address] = results.get(address, [])
94+
for result in v6_result:
95+
results[address].append(result.to_text())
96+
except Exception as e:
97+
#can not resolve #####add logging
98+
pass
10199

102100
return results
103101

@@ -114,18 +112,17 @@ def reverse_dns_multi(addresses, timeout=60):
114112
if address in ip_hosts:
115113
results[address] = results.get(address, [])
116114
results[address] += ip_hosts[address]
117-
118-
else:
119-
#dns reverse lookup
120-
try:
121-
resolver_result = res.query(dns.reversename.from_address(address), 'PTR')
122-
if resolver_result:
123-
results[address] = results.get(address, [])
124-
for result in resolver_result:
125-
results[address].append(str(result).rstrip('.'))
126-
except Exception as e:
127-
#can not resolve #####add logging
128-
pass
115+
116+
#dns reverse lookup
117+
try:
118+
resolver_result = res.query(dns.reversename.from_address(address), 'PTR')
119+
if resolver_result:
120+
results[address] = results.get(address, [])
121+
for result in resolver_result:
122+
results[address].append(str(result).rstrip('.'))
123+
except Exception as e:
124+
#can not resolve #####add logging
125+
pass
129126
return results
130127

131128

0 commit comments

Comments
 (0)