Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http potential vulnerability #463

Open
rhclopes opened this issue Mar 6, 2024 · 4 comments
Open

http potential vulnerability #463

rhclopes opened this issue Mar 6, 2024 · 4 comments

Comments

@rhclopes
Copy link

rhclopes commented Mar 6, 2024

QMUL have just contacted Jisc about two potential vulnerabilities in the perfSONAR toolkit web page.

(0) The toolkit Does Not Implement HSTS Best Practices Not implementing HTTP Strict Transport Security (HSTS)

I believe this casn be easily fixed by adding to the file apache-toolkit_web_gui-le-ssl.conf the line

Header always set Strict-Transport-Security "max-age=31536000; includeSubDomains"

I have done it for ps-slough-lat.ja.net.

Can some security wizzard check/amend?

(1) Site Does Not Use Best Practices Against Embedding of Malicious Content Not using X-Frame-Options means greater vulnerability to clickjacking attacks.

I am puzzling on that.

Raul

@rhclopes
Copy link
Author

rhclopes commented Mar 6, 2024

Can the second issue, related to X-frame be fixed by adding the line

Header always set X-Frame-Options "SAMEORIGIN"

to httpd.conf.

Raul

@arlake228
Copy link
Contributor

For the X-Frame thing we are aware of this, we can't change this without breaking MaDDash and the graphs. This is one reason of many of why MaDDash and the graphs are going away in next release.

We can look into the HSTS thing and if it makes sense in all cases. It's probably safe to do...and i feel like we looked at before? Just need to make sure it doesn't break anything. As you have noted, users have the ability to adjust the configuration to whatever their requirements may be.

@rhclopes
Copy link
Author

rhclopes commented Mar 6, 2024

I've applied fixes to Jisc London and Jisc Slough. My limited security skills say the fixes work. I am waiting for the QMUL pen tester.

Please feel free to poke any of the Jisc hosts

@timchown
Copy link

timchown commented Mar 7, 2024

The other thing we could do is add some comments in the documentation about such settings. Perhaps an additional section on this page? https://www.perfsonar.net/deployment_security.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

3 participants