Skip to content

Commit

Permalink
Add TODOs, see #1549
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Jan 23, 2025
1 parent e730bda commit bae2281
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions js/common/pre-commit/pre-commit-task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ const repo = getArg( 'repo' );
const exists = fs.existsSync( `../${testFilePath}` );
if ( exists ) {

// TODO: Everything is a cache miss at the moment, see https://github.com/phetsims/chipper/issues/1549
if ( CacheLayer.isCacheSafe( cacheKey ) ) {
return true;
}
Expand Down Expand Up @@ -201,6 +202,7 @@ const repo = getArg( 'repo' );
.filter( phetioSimRepo => getPhetLibs( phetioSimRepo ).includes( repo ) )

// Only worry about the ones that are not cached
// TODO: Everything is a cache miss at the moment, see https://github.com/phetsims/chipper/issues/1549
.filter( repo => !CacheLayer.isCacheSafe( getCacheKey( repo ) ) );

if ( reposToTest.length > 0 ) {
Expand Down

0 comments on commit bae2281

Please sign in to comment.