From bae22812216c939af4ada1b974352fd7a035470b Mon Sep 17 00:00:00 2001 From: Sam Reid Date: Thu, 23 Jan 2025 12:32:34 -0700 Subject: [PATCH] Add TODOs, see https://github.com/phetsims/chipper/issues/1549 --- js/common/pre-commit/pre-commit-task.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/js/common/pre-commit/pre-commit-task.ts b/js/common/pre-commit/pre-commit-task.ts index 8fa70518..c95200e8 100644 --- a/js/common/pre-commit/pre-commit-task.ts +++ b/js/common/pre-commit/pre-commit-task.ts @@ -103,6 +103,7 @@ const repo = getArg( 'repo' ); const exists = fs.existsSync( `../${testFilePath}` ); if ( exists ) { + // TODO: Everything is a cache miss at the moment, see https://github.com/phetsims/chipper/issues/1549 if ( CacheLayer.isCacheSafe( cacheKey ) ) { return true; } @@ -201,6 +202,7 @@ const repo = getArg( 'repo' ); .filter( phetioSimRepo => getPhetLibs( phetioSimRepo ).includes( repo ) ) // Only worry about the ones that are not cached + // TODO: Everything is a cache miss at the moment, see https://github.com/phetsims/chipper/issues/1549 .filter( repo => !CacheLayer.isCacheSafe( getCacheKey( repo ) ) ); if ( reposToTest.length > 0 ) {