From 45e808518ba21170dbde30ef96bb47e89da2eaed Mon Sep 17 00:00:00 2001 From: pixelzoom Date: Thu, 12 Dec 2024 10:44:11 -0700 Subject: [PATCH] document why Property will not be PhET-iO instrumented, https://github.com/phetsims/number-pairs/issues/22 --- js/common/model/NumberPairsPreferences.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/common/model/NumberPairsPreferences.ts b/js/common/model/NumberPairsPreferences.ts index 6bfb55a..3170ffe 100644 --- a/js/common/model/NumberPairsPreferences.ts +++ b/js/common/model/NumberPairsPreferences.ts @@ -33,10 +33,10 @@ const NumberPairsPreferences = { // Second locale secondLocaleProperty: secondLocaleProperty, - // Voice for the primary locale + // Voices for the primary and second locale. At 12/12/24 PhET-iO meeting, we decided that these Properties will + // not be instrumented for PhET-iO. SpeechSynthesisVoice is a native JavaScript type, so creating an IOType is + // problematic. And it doesn’t make sense to configure in a wrapper, because available voices are platform specific. primaryVoiceProperty: new Property( null ), - - // Voice for the second locale secondVoiceProperty: new Property( null ), // When true, the phrase will automatically be spoken whenever it changes.