Refactor drag speed options and improve visibility property constants…

… in drag interaction views, see: #77
phetsims · Jan 31, 2025 · edf951a · edf951a
1 parent 1189a64
commit edf951a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/js/common/view/GroupSelectDragInteractionView.ts b/js/common/view/GroupSelectDragInteractionView.ts
@@ -57,6 +57,8 @@ export default class GroupSelectDragInteractionView extends GroupSelectView<Coun
     super( groupSelectModel, primaryFocusedNode, options );
 
     const keyboardListenerOptions = combineOptions<SoundKeyboardDragListenerOptions>( {
+      dragSpeed: 180,
+      shiftDragSpeed: 90,
       enabledProperty: groupSelectModel.isGroupItemKeyboardGrabbedProperty,
       tandem: options.tandem.createTandem( 'keyboardDragListener' )
     }, options.soundKeyboardDragListenerOptions );

diff --git a/js/common/view/NumberBondAccordionBox.ts b/js/common/view/NumberBondAccordionBox.ts
@@ -19,6 +19,7 @@ import NumberBondNode, { NumberBondNodeOptions } from './NumberBondNode.js';
 import TotalRepresentationAccordionBox, { TotalRepresentationAccordionBoxOptions } from './TotalRepresentationAccordionBox.js';
 import BarModelNode from './BarModelNode.js';
 import DerivedProperty from '../../../../axon/js/DerivedProperty.js';
+import { NumberModelType } from './NumberModelTypeControl.js';
 
 type SelfOptions = {
   numberBondNodeOptions?: NumberBondNodeOptions;
@@ -43,11 +44,11 @@ export default class NumberBondAccordionBox extends TotalRepresentationAccordion
     }, providedOptions );
 
     const numberBondOptions = combineOptions<NumberBondNodeOptions>( {
-      visibleProperty: DerivedProperty.valueEqualsConstant( NumberPairsConstants.NUMBER_MODEL_TYPE_PROPERTY, 'numberBondModel' )
+      visibleProperty: DerivedProperty.valueEqualsConstant( NumberPairsConstants.NUMBER_MODEL_TYPE_PROPERTY, NumberModelType.NUMBER_BOND_MODEL )
     }, options.numberBondNodeOptions );
     const numberBondNode = new NumberBondNode( model, numberBondOptions );
     const barModelNode = new BarModelNode( model, {
-      visibleProperty: DerivedProperty.valueEqualsConstant( NumberPairsConstants.NUMBER_MODEL_TYPE_PROPERTY, 'barModel' )
+      visibleProperty: DerivedProperty.valueEqualsConstant( NumberPairsConstants.NUMBER_MODEL_TYPE_PROPERTY, NumberModelType.BAR_MODEL )
     } );
     const contentNode = new Node( {
       children: [ numberBondNode, barModelNode ],