Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine showHideBothAddendsButton instrumentation #90

Open
marlitas opened this issue Feb 13, 2025 · 3 comments
Open

Refine showHideBothAddendsButton instrumentation #90

marlitas opened this issue Feb 13, 2025 · 3 comments
Assignees
@pixelzoom @marlitas
Labels
dev:phet-io

Comments

@marlitas
Copy link
Contributor

We want to:

  • Uninstrument in screens it is not used
  • Instrument the visibleProperty as well as the enabledProperty
@marlitas marlitas self-assigned this Feb 13, 2025
@pixelzoom
Copy link
Collaborator

pixelzoom commented Feb 25, 2025 •
edited
Loading

Note that PhET typically avoids using "show" and "hide" in tandem names. "Visible" is the preferred naming convention, in this case bothAddendsVisibleProperty: Property<boolean>.

@marlitas marlitas changed the title Refine showHideBothAddends instrumentation Refine showHideBothAddendsButton instrumentation Feb 27, 2025
@marlitas
Copy link
Contributor Author

I updated the title but this is actually in reference to a button. Perhaps I should rename to the button's class name EyeToggleButton. That might be more appropriate.

@marlitas
Copy link
Contributor Author

This button also needs a GatedVisibleProperty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

@marlitas marlitas

Labels
dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @marlitas