Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move KeyboardDragListener to scenery #913

Closed
zepumph opened this issue Dec 18, 2018 · 7 comments
Closed

Move KeyboardDragListener to scenery #913

zepumph opened this issue Dec 18, 2018 · 7 comments

Comments

@zepumph
Copy link
Member

zepumph commented Dec 18, 2018

It makes the most sense for a base listener like this to live in scenery.

@zepumph
Copy link
Member Author

zepumph commented Feb 11, 2019

Because of work done in #884, we are ready to move this over to scenery now. Marking high so that we can write scenery a11y examples of it before CSUN.

@zepumph
Copy link
Member Author

zepumph commented Feb 23, 2019

@twant perhaps next week we can work on this together. I don't want to confuse you too much too early, but it could be nice to have you along for some common code work. (what do you think @jessegreenberg?)

@twant
Copy link
Contributor

twant commented Feb 25, 2019

@zepumph sounds good to me to take a look at it this week! Talk to you soon.

zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Feb 26, 2019
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Feb 26, 2019
zepumph added a commit to phetsims/scenery-phet that referenced this issue Feb 26, 2019
zepumph added a commit to phetsims/faradays-law that referenced this issue Feb 26, 2019
zepumph added a commit to phetsims/friction that referenced this issue Feb 26, 2019
zepumph added a commit that referenced this issue Feb 26, 2019
@zepumph
Copy link
Member Author

zepumph commented Feb 26, 2019

@twant and I used

copy-history-to-different-repo.sh js/accessibility/listeners/KeyboardDragListener.js ../scenery

To copy the history of the file over to scenery.

We then converted the 5 usages to point to the scenery version. The doc we added was to try to make sure that users know that the file is heavily reliant on AXON/timer.

@jessegreenberg will you please review.

@zepumph zepumph removed their assignment Feb 26, 2019
zepumph added a commit to phetsims/area-model-common that referenced this issue Feb 26, 2019
@zepumph
Copy link
Member Author

zepumph commented Mar 4, 2019

@twant pointed out that she was getting an error trying to use this in the built version of scenery. After investigation it looks like we weren't adding it the SCENERY/main.js. @jessegreenberg over to you.

@jessegreenberg
Copy link
Contributor

This is very old, big ping to myself to review while I do #1054.

@jessegreenberg
Copy link
Contributor

Great to have this in scenery. Usages look great. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants