-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move KeyboardDragListener to scenery #913
Comments
Because of work done in #884, we are ready to move this over to scenery now. Marking high so that we can write scenery a11y examples of it before CSUN. |
@twant perhaps next week we can work on this together. I don't want to confuse you too much too early, but it could be nice to have you along for some common code work. (what do you think @jessegreenberg?) |
@zepumph sounds good to me to take a look at it this week! Talk to you soon. |
@twant and I used
To copy the history of the file over to scenery. We then converted the 5 usages to point to the scenery version. The doc we added was to try to make sure that users know that the file is heavily reliant on @jessegreenberg will you please review. |
@twant pointed out that she was getting an error trying to use this in the built version of scenery. After investigation it looks like we weren't adding it the SCENERY/main.js. @jessegreenberg over to you. |
This is very old, big ping to myself to review while I do #1054. |
Great to have this in scenery. Usages look great. Closing |
It makes the most sense for a base listener like this to live in scenery.
The text was updated successfully, but these errors were encountered: