Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a11y event types in Input.js #929

Closed
zepumph opened this issue Jan 22, 2019 · 4 comments
Closed

Document a11y event types in Input.js #929

zepumph opened this issue Jan 22, 2019 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jan 22, 2019

@pixelzoom brought the lack of documentation to light today in the a11y-dev channel. Items to do:

  1. Add documentation at the top of the file, like around the Event Types section.
  2. Add better documentation to A11Y_EVENT_TYPES
  3. Ask @pixelzoom to review
@zepumph zepumph self-assigned this Jan 22, 2019
@zepumph
Copy link
Member Author

zepumph commented Jan 29, 2019

Note from meetings today with @jessegreenberg and @emily-phet. Regarding #939, I wonder if we shouldn't put a fair bit of information regarding how certain a11y related keyboard events behave (a) given a certain tag name, and (b) depending on if a screen reader is active.

@pixelzoom
Copy link
Contributor

The more documentation, the better. Also useful to identify things that are a11y standards vs PhET standards.

@zepumph
Copy link
Member Author

zepumph commented Jul 9, 2019

@pixelzoom please review.

@pixelzoom
Copy link
Contributor

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants