Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberSpinner support for dynamic layout. #918

Open
pixelzoom opened this issue Dec 3, 2024 · 3 comments
Open

NumberSpinner support for dynamic layout. #918

pixelzoom opened this issue Dec 3, 2024 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

Discovered in phetsims/fourier-making-waves#250 ...

NumberSpinner does not support dynamic layout. Like NumberControl, it should probably extend Sizable and resize its NumberDisplay accordingly. (And does dynamic layout also need to be added to NumberDisplay?)

This is not blocking for phetsims/fourier-making-waves#250.

Assigning to @jonathanolson, since he added dynamic layout to most of the other common-code UI components, so is probably most familar with this.

@pixelzoom
Copy link
Contributor Author

@jonathanolson Can you provide an estimate on how difficult this is, and when it might be available? We're evaluating for phetsims/fourier-making-waves#247.

@jonathanolson
Copy link
Contributor

I'm not particularly familiar with NumberSpinner. It looks like uses a very imperative one-time setup for layout, and it seems to sport a lot of layout options:

image

So it already looks to be a fairly high-cost thing to understand/rewrite a good number of layouts.

Also, would it resize the NumberDisplay? I thought NumberDisplay was specifically designed as a fairly fixed-size component.

For me to do it would be a good amount of work. Perhaps for this, it might make more sense for me to bring @pixelzoom or someone more familiar with the uses/needs up to speed on the approaches used in other components.

@pixelzoom
Copy link
Contributor Author

Thanks for the info @jonathanolson. We'll punt on this for phetsims/fourier-making-waves#250, and discuss next steps via the Developer Priorities board.

@pixelzoom pixelzoom removed their assignment Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants