Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin is unable to cleanup after journal is removed #68

Closed
jonasraoni opened this issue Feb 21, 2023 · 0 comments · Fixed by #73 or #74
Closed

Plugin is unable to cleanup after journal is removed #68

jonasraoni opened this issue Feb 21, 2023 · 0 comments · Fixed by #73 or #74
Assignees
@jonasraoni
Labels
bug Something isn't working Bug:1:Low
Milestone
2.0.4-3

Comments

@jonasraoni
Copy link
Collaborator

There's some code to cleanup data here:

pln/PLNPlugin.inc.php

Line 92 in 49f2b90

HookRegistry::register('JournalDAO::deleteJournalById', array($this, 'callbackDeleteJournalById'));

But it depends on a non-existent hook, and at the administrative part (/admin/contexts) where the journal is supposed to be removed, standard plugins are not loaded, so there's no way to listen for the right hook (Context::delete).

The cleanup might be done inside the scheduled task.
Another possibility would be to investigate the behavior of enabling the "site-wide" setting, which would be the only way to get the plugin loaded at the right time.
@jonasraoni jonasraoni added bug Something isn't working Bug:1:Low labels Feb 21, 2023
@jonasraoni jonasraoni added this to the 2.0.4-3 milestone Feb 21, 2023
@jonasraoni jonasraoni self-assigned this Feb 21, 2023
@jonasraoni jonasraoni moved this from Backlog to Under Development in Plugins and Themes Feb 22, 2023
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Added notification to remind users to accept the terms after e…
dfb93f7 
…nabling the plugin
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Added notification to remind users to accept the terms after e…
0b8ea4b 
…nabling the plugin
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Dropped invalid hook handler
b112238
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Dropped invalid hook handler
fce88a2
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Added method to remove packages
91116c7
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Replaced deleteByJournalId() by pruneOrphaned()
13d1f4d
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Added pruneOrphaned method to the Depositor
5187214
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Added method to remove packages
04e624a
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Fixed type hint
855cd3b
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Replaced deleteByJournalId() by pruneOrphaned()
4c7ef2b
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Added pruneOrphaned method to the Depositor
30d2439
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 23, 2023
@jonasraoni
pkp#68 Dropped non-existent LOCKSS states
725c9e7
This was linked to pull requests Feb 23, 2023
Bugfix/main/68 fix journal cleanup #73
Merged
Bugfix/stable 3 3 0/68 fix journal cleanup #74
Merged
@github-project-automation github-project-automation bot moved this from Under Development to Done in Plugins and Themes Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

Labels
bug Something isn't working Bug:1:Low
Projects
Plugins and Themes
Status: Done
Milestone
2.0.4-3
1 participant
@jonasraoni