Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileFormats/CHK: save is incorrect and round-trip inconsistent #147

Open
myocytebd opened this issue Jun 30, 2024 · 1 comment
Open

FileFormats/CHK: save is incorrect and round-trip inconsistent #147

myocytebd opened this issue Jun 30, 2024 · 1 comment

Comments

@myocytebd
Copy link

  • A few minor bugs on CHK save;
  • STR section is round-trip inconsistent;
  • TRIG/MBRF sections are round-trip inconsistent.

(.txt due to github bug)
0001-FileFormats-CHK-fix-CHK-save-and-add-round-trip-test.patch.txt

  • Fix a few minor bugs on CHK save/load.
  • Make STR section usually round-trip consistent.
  • Add an option to bypass TRIG/MBRF decompilation.
  • Add a round-trip test.
    With TRIG/MBRF disabled, most SC:R locales/enUS/Assets/campaign/ chk files are round-trip exact, except locales/enUS/Assets/campaign/EXPTerran/Terran04/staredit/scenario_rev4.chk (STR section has same strings but not byte accurate).
@poiuyqwert
Copy link
Owner

Hey @myocytebd, thanks for the details. The CHK stuff definitely has the least amount of love put into it since it isnt much called for by modders, and was mostly a fun side thing for me. I would love to get it fixed up and more feature rich, so I am glad to get any input/feadback you have. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants