From a648478088d276ab53cbf23003069cdac995d86b Mon Sep 17 00:00:00 2001 From: Ritchie Vink Date: Tue, 30 Jan 2024 17:25:38 +0100 Subject: [PATCH] perf: elide unneeded work in window? (#14108) --- .../src/physical_plan/expressions/window.rs | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/crates/polars-lazy/src/physical_plan/expressions/window.rs b/crates/polars-lazy/src/physical_plan/expressions/window.rs index 3ccac3a9a00d..28fe7ce47778 100644 --- a/crates/polars-lazy/src/physical_plan/expressions/window.rs +++ b/crates/polars-lazy/src/physical_plan/expressions/window.rs @@ -685,20 +685,6 @@ where T: PolarsNumericType, ChunkedArray: IntoSeries, { - let mut idx_mapping = Vec::with_capacity(len); - let mut iter = 0..len as IdxSize; - match groups { - GroupsProxy::Idx(groups) => { - for g in groups.all() { - idx_mapping.extend((&mut iter).take(g.len()).zip(g.iter().copied())); - } - }, - GroupsProxy::Slice { groups, .. } => { - for &[first, len] in groups { - idx_mapping.extend((&mut iter).take(len as usize).zip(first..first + len)); - } - }, - } let mut values = Vec::with_capacity(len); let ptr: *mut T::Native = values.as_mut_ptr(); // safety: