[AHM] Scheduler Pallet #569
Conversation
| @@ -267,6 +274,16 @@ pub mod pallet { | |||
| count_bad: u32, | |||
| }, | |||
| ReferendaProcessed, | |||
| SchedulerMessagesReceived { | |||
There was a problem hiding this comment.
I added a generic variant with a PalletName that we can use as to not copy&paste this always for new pallets.
| ) -> Result<Option<Self::Key>, Self::Error> { | ||
| let mut last_key = last_key.unwrap_or(SchedulerStage::IncompleteSince); | ||
| let mut messages = Vec::new(); | ||
|
|
There was a problem hiding this comment.
We also have to go through all pallets on_initialize code and possibly disable it during the migration. Otherwise some pallets may break from partial state being migrated. I will add it as TODO
There was a problem hiding this comment.
Right. I have an idea how to do it for the scheduler
| }, | ||
| SchedulerStage::Agenda(last_key) => { | ||
| let mut iter = if let Some(last_key) = last_key { | ||
| alias::Agenda::<T>::iter_from_key(last_key) |
There was a problem hiding this comment.
Not sure if you have to call hashed_key_for. Did you try it it migrates all?
There was a problem hiding this comment.
I think so, I will double check. I used iter_from_key for all other pallets migrations
There was a problem hiding this comment.
Yea but it is tricky since it sometimes does still catch a subset. We will see when testing, it could be a likely culprit when entries are missing.
pallets/ah-migrator/src/call.rs
Outdated
| return Err(Error::<T>::FailedToConvertCall); | ||
| }; | ||
|
|
||
| log::info!("MAPPED CALL: {:?}", call); |
I thought about it, and I think the simplest is to just migrate it. We might have passed referendums' calls that scheduled to be enacted. Also we have referenda pallet's service calls that already scheduled. We pause the scheduler for the time of migration and those overdue call would just be dispatched when migration ends. Otherwise we need some custom logic for these calls. The presented approach seems to be the simplest to me. |
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Yea sounds good. |
ggwpez
merged commit 74e3980
into
polkadot-fellows:dev-asset-hub-migration
meant to be merged into
dev-asset-hub-migrationThe migration for the Scheduler pallet from Relay Chain to Asset Hub.