polkit-126: assert on polkitd startup when configured & built with "--prefix=/usr/local"

[z1atk0]

Describe the bug
When configured & built with --prefix=/usr/local, polkitd from polkit-126 errors out with an assertion on startup (I reverted to polkit-125 for the time being, that's why I started it using LD_LIBRARY_PATH to make sure it's linking against its matching libs):

[root@disclosure:~/usrlocal/stow]# LD_LIBRARY_PATH=/usr/local/stow/polkit-126-@FDO/lib64 /usr/local/stow/polkit-126-@FDO/lib/polkit-1/polkitd 
Successfully changed to user polkitd
20:49:19.783: Loading rules from directory /usr/local/etc/polkit-1/rules.d
20:49:19.784: Loading rules from directory /run/polkit-1/rules.d
20:49:19.784: Loading rules from directory /usr/local/share/polkit-1/rules.d
20:49:19.784: Loading rules from directory /usr/local/share/polkit-1/rules.d
**
ERROR:../src/polkitbackend/polkitbackendcommon.c:475:polkit_backend_common_rules_file_name_cmp: assertion failed: (ret != 0)
Bail out! ERROR:../src/polkitbackend/polkitbackendcommon.c:475:polkit_backend_common_rules_file_name_cmp: assertion failed: (ret != 0)
Aborted

If I interpret the corresponding code correctly, then this probably originates from

polkit/src/polkitbackend/polkitbackendduktapeauthority.c

Line 259 in 939c1a9

authority->priv->rules_dirs[2] = g_strdup ("/usr/local/share/polkit-1/rules.d");

where /usr/local/share/polkit-1/rules.d gets added to the list of rules_dirs, leading to a duplicate path entry in

polkit/src/polkitbackend/polkitbackendduktapeauthority.c

Line 260 in 939c1a9

authority->priv->rules_dirs[3] = g_strdup (PACKAGE_DATA_DIR "/polkit-1/rules.d");

when configured with --prefix=/usr/local, which ultimately assert()s in

polkit/src/polkitbackend/polkitbackendcommon.c

Line 475 in 939c1a9

g_assert (ret != 0);

when trying to figure out which entry takes precedence, which is impossible when comparing two exactly identical entries.

Up to and including polkit-125, I used to build with meson setup --prefix=/usr/local -D js_engine=mozjs, and there were no duplicate path entries generated in

polkit/src/polkitbackend/polkitbackendjsauthority.cpp

Lines 402 to 407 in 112752c

	if (authority->priv->rules_dirs == NULL)
	{
	authority->priv->rules_dirs = g_new0 (gchar *, 3);
	authority->priv->rules_dirs[0] = g_strdup (PACKAGE_SYSCONF_DIR "/polkit-1/rules.d");
	authority->priv->rules_dirs[1] = g_strdup (PACKAGE_DATA_DIR "/polkit-1/rules.d");
	}

To Reproduce
Steps to reproduce the behavior:

1. Configure polkit-126 with meson setup --prefix=/usr/local, then build as usual
2. Install to /usr/local with ninja install
3. Wait for polkitd to be activated via d-bus, or ...
4. ... try to start it manually with /usr/local/lib/polkit-1/polkitd

Expected behavior
I expected polkitd to startup properly as usual, when built with -D js_engine=mozjs in earlier versions. 🤷‍♂️ 😉

Screenshots
N/A, see terminal output above.

Desktop (please complete the following information):

• OS (including version): Slackware64-15.0
• Desktop Environment [Gnome, KDE, ...]: GNOME 47 (self-compiled)
• Version of polkit: 126

Additional context
As I said before, I built against mozjs in previous versions, which didn't exhibit this behavior, as it didn't create duplicate entries in rules_dirs.

There's no output in the logs except for the startup notification ("Jan 15 20:49:19 disclosure polkitd[20392]: Started polkitd version 126").

If you need any additional information, plesae let me know. Thanks for listening! 🙂

Thomas