Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long code cannot be shared #24

Open
aversey opened this issue Jul 10, 2023 · 1 comment
Open

Long code cannot be shared #24

aversey opened this issue Jul 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@aversey
Copy link
Contributor

aversey commented Jul 10, 2023

Since the share function currently puts the whole code in a query string, and a URL length is limited (browser-dependent, on my machine for Firefox the limit is around 8000 characters), long code cannot be shared.

@aversey aversey added the bug Something isn't working label Jul 10, 2023
@aversey
Copy link
Contributor Author

aversey commented Jul 10, 2023

I suggest using key-value storage with hash of code mapped to the code itself. Then “share” button computes a hash of code, saves the pair in storage and returns the URL with the hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant