From e334f8e5e70fabb7540b84ab31a9da6d0876618c Mon Sep 17 00:00:00 2001 From: Tim Mok Date: Thu, 16 Jan 2025 09:32:45 -0500 Subject: [PATCH] Compare build numbers (#6011) Fix build number comparison when checking for updates --- src/vs/platform/update/electron-main/abstractUpdateService.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/platform/update/electron-main/abstractUpdateService.ts b/src/vs/platform/update/electron-main/abstractUpdateService.ts index 9293323d58a..28c49f51e7a 100644 --- a/src/vs/platform/update/electron-main/abstractUpdateService.ts +++ b/src/vs/platform/update/electron-main/abstractUpdateService.ts @@ -198,11 +198,11 @@ export abstract class AbstractUpdateService implements IUpdateService { return Promise.resolve(null); } - if (hasUpdate(update, this.productService.positronVersion)) { + if (hasUpdate(update, `${this.productService.positronVersion}-${this.productService.positronBuildNumber}`)) { this.logService.info(`update#checkForUpdates, ${update.version} is available`); this.updateAvailable(update); } else { - this.logService.info(`update#checkForUpdates, ${this.productService.positronVersion} is the latest version`); + this.logService.info(`update#checkForUpdates, ${this.productService.positronVersion}-${this.productService.positronBuildNumber} is the latest version`); this.setState(State.Idle(this.getUpdateType())); } return Promise.resolve(update);