Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use posit cdn instead of github release asset for download url #6496

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+13 −15
Open

use posit cdn instead of github release asset for download url #6496

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17e96ec
use posit cdn instead of github release asset for download url
sharon-wang Feb 26, 2025
f1af522
import url lib to get URL
sharon-wang Feb 26, 2025
9e1bd86
use `new URL` instead of `URL.parse()`
sharon-wang Feb 26, 2025
626b5bb
use switch for consistency with previous platform checks
sharon-wang Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions extensions/positron-python/src/test/positron/testElectron.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*---------------------------------------------------------------------------------------------
* Copyright (C) 2024 Posit Software, PBC. All rights reserved.
* Copyright (C) 2025 Posit Software, PBC. All rights reserved.
* Licensed under the Elastic License 2.0. See LICENSE.txt for license information.
*--------------------------------------------------------------------------------------------*/

Expand Down Expand Up @@ -240,22 +240,11 @@ export async function downloadAndUnzipPositron(): Promise<{ version: string; exe
case 'darwin':
suffix = '.dmg';
break;
case 'linux':
suffix = '.deb';
break;
case 'win32':
suffix = '.exe';
break;
Comment on lines -243 to -248
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this as it doesn't seem like we support linux/win32 anyways? See lower down in this function where we look for the executablePath -- only mac is supported there.

default: {
throw new Error(`Unsupported platform: ${platform}.`);
}
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const asset = release.assets.find((a: any) => a.name.endsWith(suffix));
if (!asset) {
throw new Error(`No asset found with suffix ${suffix} for platform ${platform}`);
}
Comment on lines -255 to -258
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where the error was occurring. We no longer publish assets for the binaries.

const version = release.tag_name;
console.log(`Using ${version} build of Positron`);

Expand All @@ -280,8 +269,18 @@ export async function downloadAndUnzipPositron(): Promise<{ version: string; exe
}
}

console.log(`Downloading Positron for ${platform} from ${asset.url}`);
const url = new URL(asset.url);
let fileName: string;
let url: URL | undefined;
switch (platform) {
case 'darwin':
fileName = `Positron-${version}${suffix}`;
url = new URL(`https://cdn.posit.co/positron/prereleases/mac/universal/${fileName}`);
break;
default:
throw new Error(`Unsupported platform: ${platform}`);
}

console.log(`Downloading Positron for ${platform} from ${url.href}`);
// Reset the Accept header to download the asset.
headers.Accept = 'application/octet-stream';
const dlRequestOptions: https.RequestOptions = {
Expand All @@ -300,7 +299,6 @@ export async function downloadAndUnzipPositron(): Promise<{ version: string; exe

// Download to a temporary file.
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'positron-'));
const fileName = asset.name;
const downloadPath = path.join(tempDir, fileName);
try {
const writer = fs.createWriteStream(downloadPath);
Expand Down
Loading