Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mesa-geo visualisation based on updated SolaraViz API #262

Closed
EwoutH opened this issue Nov 12, 2024 · 2 comments
Closed

Update Mesa-geo visualisation based on updated SolaraViz API #262

EwoutH opened this issue Nov 12, 2024 · 2 comments
Labels
breaking Release notes label good first issue maintenance Release notes label

Comments

@EwoutH
Copy link
Member

EwoutH commented Nov 12, 2024

Since the SolaraViz API was updated, the Mesa-geo API also needs to be updated to match it. See:
@wang-boyu
Copy link
Member

Thanks for noticing this! Do you mean renaming make_geospace_leaflet to make_geospace_component to be consistent with Mesa? Anything else that I'm missing?

@wang-boyu wang-boyu added breaking Release notes label help wanted good first issue maintenance Release notes label labels Dec 15, 2024
@wang-boyu wang-boyu mentioned this issue Dec 21, 2024
Merged
@wang-boyu
Copy link
Member

Implemented in #270. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Release notes label good first issue maintenance Release notes label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wang-boyu @EwoutH