From 1b3b1c3dd94fc5f793bb3fb87dabd4634836a3ef Mon Sep 17 00:00:00 2001 From: Hrushikesh Date: Wed, 10 Jul 2024 13:51:56 -0500 Subject: [PATCH 1/2] fixed share icon display issue on android --- .../com/proyecto26/inappbrowser/RNInAppBrowser.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java b/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java index 28158ce..15331c3 100644 --- a/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java +++ b/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java @@ -133,10 +133,16 @@ public void open(Context context, final ReadableMap options, final Promise promi setColor(builder, options, KEY_NAVIGATION_BAR_COLOR, "setNavigationBarColor", "navigation bar"); setColor(builder, options, KEY_NAVIGATION_BAR_DIVIDER_COLOR, "setNavigationBarDividerColor", "navigation bar divider"); - if (options.hasKey(KEY_DEFAULT_SHARE_MENU_ITEM) && - options.getBoolean(KEY_DEFAULT_SHARE_MENU_ITEM)) { - builder.addDefaultShareMenuItem(); + if(options.hasKey(KEY_DEFAULT_SHARE_MENU_ITEM)){ + if(options.getBoolean(KEY_DEFAULT_SHARE_MENU_ITEM)){ + builder.setShareState(CustomTabsIntent.SHARE_STATE_ON); + }else{ + builder.setShareState(CustomTabsIntent.SHARE_STATE_OFF); + } + }else{ + builder.setShareState(CustomTabsIntent.SHARE_STATE_OFF); } + if (options.hasKey(KEY_ANIMATIONS)) { final ReadableMap animations = options.getMap(KEY_ANIMATIONS); applyAnimation(context, builder, animations); From 89e8d61512aa66923ea020e757342b9b47eea1d7 Mon Sep 17 00:00:00 2001 From: Hrushikesh Date: Wed, 31 Jul 2024 21:33:47 -0500 Subject: [PATCH 2/2] fixed indentation --- .../java/com/proyecto26/inappbrowser/RNInAppBrowser.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java b/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java index 15331c3..32a889b 100644 --- a/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java +++ b/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java @@ -133,13 +133,13 @@ public void open(Context context, final ReadableMap options, final Promise promi setColor(builder, options, KEY_NAVIGATION_BAR_COLOR, "setNavigationBarColor", "navigation bar"); setColor(builder, options, KEY_NAVIGATION_BAR_DIVIDER_COLOR, "setNavigationBarDividerColor", "navigation bar divider"); - if(options.hasKey(KEY_DEFAULT_SHARE_MENU_ITEM)){ - if(options.getBoolean(KEY_DEFAULT_SHARE_MENU_ITEM)){ + if (options.hasKey(KEY_DEFAULT_SHARE_MENU_ITEM)) { + if (options.getBoolean(KEY_DEFAULT_SHARE_MENU_ITEM)) { builder.setShareState(CustomTabsIntent.SHARE_STATE_ON); - }else{ + } else { builder.setShareState(CustomTabsIntent.SHARE_STATE_OFF); } - }else{ + } else { builder.setShareState(CustomTabsIntent.SHARE_STATE_OFF); }