Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessories are removed when internet access is lost. #137

Open
hjuhlin opened this issue Jan 24, 2022 · 8 comments
Open

Accessories are removed when internet access is lost. #137

hjuhlin opened this issue Jan 24, 2022 · 8 comments
Assignees
Labels

Comments

@hjuhlin
Copy link

hjuhlin commented Jan 24, 2022

Accessories are removed when internet access is lost.

I have been using you Verisure plugin for over a year without any problems.
But last week all our Verisure accessories have been removed three times.

  • First time I don’t know why all accessories was removed.
  • Second time our internet provider was here to upgrade our internet and we was out of internet for 30 min. When it was back up all Verisure accessories was removed.
  • Third time we had a power failure, and when power did get back after 3 hours our Homebridge server started before the internet providers switch was started and all accessories was removed again.

All other accessories in Homebridge where NOT affected.
So, it looks like there is some problem with the clean up old accessories code.

@ptz0n ptz0n self-assigned this Jan 24, 2022
@ptz0n
Copy link
Owner

ptz0n commented Jan 24, 2022

Thank you for reaching out. I'm running into the same issue.

I'm guessing this has to do with the dynamic nature of the platform but should be much more reliable. We do have the unique identifiers for each accessory.

@ptz0n ptz0n added bug and removed enhancement labels Jan 27, 2022
@ptz0n
Copy link
Owner

ptz0n commented Jan 27, 2022

I might have identified the issue. We are not currently checking accessories from cache. This results in cleaning of the cache if we cannot receive the device information from Verisure.

@bjornand1
Copy link

I am wondering if this is related to an issue I have seen twice over the last week: When restarting Homebridge, all my Verisure accessories are "reset", i.e., moved to the HomeKit room where the Homebridge server is located, all names set to the Verisure names, and all status settings turned on. With a fairly extensive alarm system, it takes some time to redo this.

It did not happen earlier, though, I have restarted Homebridge many times without this happening.

@ptz0n
Copy link
Owner

ptz0n commented Oct 24, 2022

Your description matches my experience perfectly and I feel the same pain. Feel free to get a PR going & I'll help out!

@larsxsamuelsson
Copy link

Without adding anything useful, i will just comment on this.
What is the difference now from before is that this usually happened when power was cut to the homebridge server. A graceful restart preserved the state. Nowadays it never preserves it, but i cannot figure out what differs from before.

@ptz0n
Copy link
Owner

ptz0n commented Mar 19, 2023

I might have identified the issue. We are not currently checking accessories from cache. This results in cleaning of the cache if we cannot receive the device information from Verisure.

@larsxsamuelsson This 👆

Backstory; previous versions made the whole Homebridge instance crash, hance no empty list of accessories.

Let's look into the caching once graphql is merged and released.

@crahan
Copy link

crahan commented May 25, 2023

Hi @ptz0n, are there any updates on this issue? My ISP cuts the internet connection around 2AM on a regular basis (every other week or so) which causes this bug to trigger. It would be awesome if the device information would be cached as each time this happens it also deletes any HomeKit automations which use these devices.

@alexkerber
Copy link

Running into the same issue here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants