Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all Dataloader subclasses as "plugins" (no built-in Dataloaders) #51

Open
lesslogic opened this issue Nov 20, 2024 · 0 comments
Labels
suggestion an idea for an enhancement or change of design

Comments

@lesslogic
Copy link

Certain data loaders are already hardcoded in PIVA. I suggest taking the current Dataloader subclasses out of data_loaders.py and implementing them on equal footing with user-made loaders (i.e., as plugins). Basically, make them "shipped" (as opposed to "built-in") features. Reasons:

  • Stability & maintainability. Reduce risk to PIVA. Community can contribute/modify the loaders without touching core code. PIVA outsources all loader maintenance.
  • Less mess for users. They can remove loaders they're not interested in. For the true globe-trotting facility users, the list of loaders can get really long. But also the majority of ARPES systems around the world are not in synchrotrons, so many or most users have no use for the built-in assortment of loaders.
  • No implied bias toward or endorsement of specific institutes, facilities or instrument manufacturers.
@pudeIko pudeIko added the suggestion an idea for an enhancement or change of design label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion an idea for an enhancement or change of design
Projects
None yet
Development

No branches or pull requests

2 participants