Add support for checkpoint distributions and publications #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
daviddavis/add-checkpoint-fields
branch
from
01f22b8 to
f65654c
Compare
mdellweg
reviewed
Jan 31, 2025
Comment on lines
+74
to
+79
| click.option( | ||
| "--checkpoint", | ||
| is_flag=True, | ||
| default=False, | ||
| help=_("Create a checkpoint distribution."), | ||
| ), |
There was a problem hiding this comment.
I think this should be tri-state: Set, unset, don't touch.
Would this work?
Suggested change
| click.option( | |
| "--checkpoint", | |
| is_flag=True, | |
| default=False, | |
| help=_("Create a checkpoint distribution."), | |
| ), | |
| click.option( | |
| "--checkpoint/--not-checkpoint", | |
| # is_flag=True, # this is implied by the "/" i think | |
| default=None, | |
| help=_("Create a checkpoint distribution."), | |
| ), |
mdellweg
reviewed
Jan 31, 2025
Comment on lines
+59
to
+64
| click.option( | ||
| "--checkpoint", | ||
| is_flag=True, | ||
| default=False, | ||
| help=_("Create a checkpoint publication"), | ||
| ), |
There was a problem hiding this comment.
Here it's only for create. This should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pulp-cli change that goes along with the new checkpoint feature: pulp/pulpcore#6245
fixes #1129