Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paramaterization to package block generation #240

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

brandonpollack23
Copy link
Contributor

@brandonpollack23 brandonpollack23 commented Dec 3, 2024

Add parameterization to pulumi package blocks.

This adds parameterization for terraform providers which require dynamic
bridging (and do not have pulumiverse or official pulumi supported packages already).

Fixes: #234

@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from 5e96a7c to ccea32b Compare December 3, 2024 01:52
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch 7 times, most recently from 004c655 to 37dfd6b Compare December 3, 2024 07:32
@brandonpollack23 brandonpollack23 changed the base branch from main to bpollack/addpackagenames December 3, 2024 07:34
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch 3 times, most recently from a46c993 to 28d1287 Compare December 3, 2024 07:45
@brandonpollack23 brandonpollack23 marked this pull request as ready for review December 3, 2024 08:01
@brandonpollack23 brandonpollack23 requested a review from a team as a code owner December 3, 2024 08:02
@brandonpollack23
Copy link
Contributor Author

The failing test is a lie, that file isn't even changed in this PR...also the file itself matches what it says it doesn't. My guess is this is another github cache problem.

@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch 2 times, most recently from 8546c4c to dfcca81 Compare December 4, 2024 05:48
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addpackagenames branch from 948be02 to eb2fdb9 Compare December 4, 2024 05:48
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from dfcca81 to 74116d9 Compare December 4, 2024 05:54
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addpackagenames branch from eb2fdb9 to 6cae4a6 Compare December 4, 2024 05:54
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from 74116d9 to b53f7d7 Compare December 4, 2024 06:07
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addpackagenames branch 2 times, most recently from 308dccb to eaf3a29 Compare December 4, 2024 06:20
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from b53f7d7 to e3dceba Compare December 4, 2024 06:20
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addpackagenames branch from eaf3a29 to f593241 Compare December 4, 2024 06:36
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from e3dceba to 2cbbd0c Compare December 4, 2024 06:36
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from 2cbbd0c to 381c7c9 Compare December 4, 2024 08:10
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addpackagenames branch from f593241 to 0ad465b Compare December 4, 2024 08:10
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from 381c7c9 to f864184 Compare December 5, 2024 05:38
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addpackagenames branch from 0ad465b to df842da Compare December 5, 2024 09:28
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch 2 times, most recently from a76ed2a to 3ccd14a Compare December 6, 2024 05:06
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addpackagenames branch 2 times, most recently from 2215b39 to df842da Compare December 6, 2024 05:11
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from 3ccd14a to a76ed2a Compare December 6, 2024 05:11
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addpackagenames branch from df842da to 9d08f32 Compare December 6, 2024 05:13
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from a76ed2a to 0c1a73d Compare December 6, 2024 05:13
Base automatically changed from bpollack/addpackagenames to main December 9, 2024 01:54
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from 0c1a73d to b9b6a20 Compare December 9, 2024 01:56
This adds parameterization for terraform providers which require dynamic
bridging (and do not have pulumiverse or official pulumi supported
packages already).
@brandonpollack23 brandonpollack23 force-pushed the bpollack/addparamaterization branch from b9b6a20 to bac6ed9 Compare December 9, 2024 08:20
@brandonpollack23 brandonpollack23 merged commit 1148f36 into main Dec 9, 2024
5 checks passed
@brandonpollack23 brandonpollack23 deleted the bpollack/addparamaterization branch December 9, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply package blocks to PCL
3 participants