Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabling compact for converter #266

Closed
wants to merge 1 commit into from

Conversation

brandonpollack23
Copy link
Contributor

@brandonpollack23 brandonpollack23 commented Jan 31, 2025

Compact is disabled but in local testing trying to make convert more powerful this seems to work.

Reenabling for now because it is not working with or without it anyway

Blocked by pulumi/pulumi-std#76
Blocked by pulumi/pulumi-std#77

Related #65
Fixes pulumi/pulumi#18406

@brandonpollack23 brandonpollack23 requested a review from a team as a code owner January 31, 2025 10:04
@brandonpollack23 brandonpollack23 changed the title Re-enabling compact. It works in local tests and is required for top modules to convert Re-enabling compact for converter Jan 31, 2025
@brandonpollack23
Copy link
Contributor Author

Test is failing not ready for reveiw

@brandonpollack23 brandonpollack23 marked this pull request as draft January 31, 2025 10:57
@brandonpollack23 brandonpollack23 changed the title Re-enabling compact for converter [DRAFT] Re-enabling compact for converter Jan 31, 2025
@brandonpollack23 brandonpollack23 changed the title [DRAFT] Re-enabling compact for converter Re-enabling compact for converter Jan 31, 2025
@brandonpollack23 brandonpollack23 force-pushed the bpollack/enable_compact branch 2 times, most recently from c97a7f5 to 462a764 Compare February 4, 2025 14:27
…modules to convert

also updates pulumi-std schema to match v1.8.0

Related #65
Fixes pulumi/pulumi#18406
@brandonpollack23 brandonpollack23 marked this pull request as ready for review February 5, 2025 09:28
@lunaris lunaris closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the compact TF/PCL function
2 participants