Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recurse submodules on lint. #718

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

recurse submodules on lint. #718

wants to merge 1 commit into from

Conversation

brandonpollack23
Copy link
Contributor

This is needed so go.mod can point to the /pulumi dir

@brandonpollack23 brandonpollack23 requested a review from a team as a code owner February 18, 2025 14:34
@brandonpollack23 brandonpollack23 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Feb 18, 2025
@brandonpollack23 brandonpollack23 mentioned this pull request Feb 18, 2025
Merged
@brandonpollack23 brandonpollack23 mentioned this pull request Feb 18, 2025
Closed
@Frassle
Copy link
Member

Frassle commented Feb 19, 2025

This isn't needed now? We're planning on not using replace for the go.mod

@brandonpollack23
Copy link
Contributor Author

This isn't needed now? We're planning on not using replace for the go.mod

not strictly but we should clone the entire repository as we do in the other projects. This will make it consistent.

@brandonpollack23
recurse submodules on lint.
026b47a 
This is needed so go.mod can point to the /pulumi dir
@brandonpollack23
Copy link
Contributor Author

This isn't needed now? We're planning on not using replace for the go.mod

not strictly but we should clone the entire repository as we do in the other projects. This will make it consistent.

scratch this, things were failing in other repos without it. A lot of the actions we do seem to fail lint or some tests without it.

@Frassle
Copy link
Member

Frassle commented Feb 21, 2025

I'm confused? Things are working fine on main without this, what's broken that needs us to do a full clone here, it's just going to slow CI down slightly isn't it?

@brandonpollack23
Copy link
Contributor Author

I'm confused? Things are working fine on main without this, what's broken that needs us to do a full clone here, it's just going to slow CI down slightly isn't it?

Ill try removing it again maybe it was a previous run or flake

@brandonpollack23 brandonpollack23 marked this pull request as draft February 25, 2025 02:25
brandonpollack23 added a commit that referenced this pull request Mar 3, 2025
@brandonpollack23 @Frassle
Add rootDirectory to yaml (#716)
d856225 
Add pulumi.rootDirectory to the yaml project generation and evalution.

This is a part of pulumi/pulumi#18565

Blocked by #718 #717 and pulumi/pulumi#18595

---------

Co-authored-by: Fraser Waters <fraser@pulumi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonpollack23 @Frassle